From: Mike Hommey <mh@glandium.org>
Date: Thu, 10 Sep 2026 12:05:31 GMT
Subject: Re: [PATCH v3] Move rust gitcore crate to a different subdirectory
Message-ID: <nqxjptlfu47fcxdep2djdv4tjtltsjacp35mncwjygv47nauru@vvx5464kcjm5>
In-Reply-To: <aqHMDErmQ0BdQlVD@fruit.crustytoothpaste.net>

On Wed, Sep 09, 2026 at 09:13:49PM +0000, brian m. carlson wrote:
> On 2026-09-09 at 01:38:58, Mike Hommey wrote:
> > Having `Cargo.toml` at the top-level of the repository implies that one
> > can run `cargo build` directly, but this doesn't produce anything useful
> > on its own.
> > 
> > Additionally, when including the git source as a submodule of a Rust
> > project, it prevents the git source from being included at all in the
> > crate package because cargo skips directories that contain a Cargo.toml,
> > assuming that everything in the directory is relevant to the crate.
> 
> So what I understand is that you have a project which has Git as a
> submodule and you want to include the Git source code into the crate
> package for that project.  In other words, you're vendoring Git to use
> its C components, but not its Rust components.

Indeed.

> If that's the case, how do you plan that to work in a few releases when
> Git 3.0 comes out and the Rust components become mandatory?

Assuming the crate doesn't grow to the point of adding a dependency on
libgit-rs or libgit-sys, I'm thinking of publishing the gitcore crate to
crates.io in a namespaced manner (although if it could be published by
the git project that would be even better).

Mike