From: Martin Mares Date: Sat, 18 Feb 2006 13:14:07 GMT Subject: Re: git-cvs-import retries Message-ID: In-Reply-To: <7v1wy1t9cb.fsf@assigned-by-dhcp.cox.net> Hi Junio! > First, one technicality. You can see what's wrong with the > above, right? Remember, the top part of your message goes into > the commit log, so we do not want "Hello!" nor signature. Sorry about that, the patch was intended more for discussion than for applying. > I read _line() three times but its return value is the lexical > variable $res which is initialized to 0 and then either reset to > 0 by assignment or updated with $res += somethingelse. So I do > not see how you can get a defined but empty string in there. You almost convinced me that my fix couldn't have changed anything :-) But it did and I finally understand why: _line() can exit not only by return, but also by falling over when readline() returns undef. In this case, something weird is returned (the most recent expression evaluated) and it's *sometimes* the empty string. I will send a new patch. Have a nice fortnight -- Martin `MJ' Mares http://atrey.karlin.mff.cuni.cz/~mj/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth The first myth of management is that it exists.