From: Jakub Narebski <jnareb@gmail.com>
Date: Sat, 03 Jul 2010 07:59:24 GMT
Subject: Re: [PATCH] Bugfix: grep: Do not colorize output when -O is set
Message-ID: <m3wrtdm1y9.fsf@localhost.localdomain>
In-Reply-To: <AANLkTilI0NZiDk3I850x28pr5I0sYRiPLW7HAST9sduU@mail.gmail.com>

Nazri Ramliy <ayiehere@gmail.com> writes:
 
> Something like the following will do (I'm doing this in gmail so sorry
> for any tabs<->space conversion):
> 
> test_expect_success 'copes with color.ui' '
>        rm -f actual &&
>        echo grep.h >expect &&
>        git config color.ui always &&
>        git config color.grep.filename yellow &&
>        test_when_finished "git config --unset color.ui" &&
>        test_when_finished "git config --unset color.grep.filename" &&
>        git grep -O'\''printf "%s\n" >actual'\'' GREP_AND &&
>        test_cmp expect actual
> '

Sidenote: test_when_finished, introduced by Jonathan Nieder in 3bf7886
(test-lib: Let tests specify commands to be run at end of test,
2010-05-02) is not documented in t/README.  Also, shouldn't it be
named 'when_finished_test' rather than 'test_when_finished'?

Currently 'test_when_finished' / 'when_finished_test' is used only in
t0000-basic and t7509-commit.

-- 
Jakub Narebski
Poland
ShadeHawk on #git