From: Jakub Narebski Date: Fri, 05 Jun 2009 20:44:56 GMT Subject: Re: [PATCH 04/23] http-push: send out fetch requests on queue Message-ID: In-Reply-To: <20090606000137.ff05ba37.rctay89@gmail.com> Tay Ray Chuan writes: > Previously, requests for remote files were simply added to the queue > (pointed to by request_queue_head) and no transfer actually took > place[1], even though code that followed may rely on these remote files ^^^ ^^^--- you have footnote reference, but no footnote > to be present (eg. the setup_revisions invocation). > > The code that sends out the requests on the request queue is refactored > into the method run_request_queue. > > After the get_dav_remote_heads invocation (ie. after fetch requests are > added to the queue), the requests on the queue are sent out through an > invocation to run_request_queue. > > This invocation to run_request_queue entails adding a fill function > before pushing checks take place, which may lead to accidental, > unwanted pushes previously. > > The flag is_running_queue is introduced to prevent this from occurring. > fill_active_slot is made to check the flag is_running_queue before > the sending of the requests proceeds. > > Signed-off-by: Tay Ray Chuan > --- [...] -- Jakub Narebski Poland ShadeHawk on #git