From: Jakub Narebski Date: Mon, 02 Feb 2009 09:56:57 GMT Subject: Re: [PATCH] builtin-config: add --exec-editor for use in scripts Message-ID: In-Reply-To: <7v4ozdo7yt.fsf@gitster.siamese.dyndns.org> Junio C Hamano writes: > Eric Wong writes: > > > This exposes the launch_editor() library function for use by > > various scripting languages. This allows the ensure consistent > > handling of GIT_EDITOR/VISUAL/EDITOR environment variables as > > well as the handling of special characters such as spaces in the > > various environment variables. > > > > Signed-off-by: Eric Wong > > --- > > > > I'm not sure if git-config is the best place to stick it. I plan to > > start using this in git-svn but I don't want to implement Git::Editor > > in Perl and have to keep track of editor.c. Of course this also makes > > the logic/rules used in libgit usable to any other scripting language > > capable of launching other programs. > > I agree that git-config is probably a wrong place. A separate command > "git editor" (or "git user-preference --editor", if you extend it to pager > and others) perhaps? > > I also agree that something like this would make scripting Porcelains a > much pleasant experience. I don't think this is something that should be put in 'git rev-parse', but perhaps a bit obscure 'git var' (print a git logical variable) would be a good place for that? -- Jakub Narebski Poland ShadeHawk on #git