From: Andreas Schwab Date: Mon, 07 Nov 2011 13:12:28 GMT Subject: Re: [PATCH 3/3] grep: get rid of useless x < 0 comparison on an enum member Message-ID: In-Reply-To: Ævar Arnfjörð Bjarmason writes: > I.e. we'll always have GREP_HEADER_AUTHOR = 0 and > GREP_HEADER_COMMITTER = 1, we'll never have GREP_HEADER_AUTHOR = and > GREP_HEADER_COMMITTER = . That is irrelevant. You can always assign -1 to an object of enumerated type and the implicit conversion to the underlying type is fully defined, no matter what type the compiler choses. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."