From: Raja R Harinath <rharinath@novell.com>
Date: Fri, 11 Nov 2005 06:58:08 GMT
Subject: Re: [PATCH] C implementation of the 'git' program.
Message-ID: <m3lkzv4qnz.fsf@harinath.blr.novell.com>
In-Reply-To: <20051110182631.3C5615BF90@nox.op5.se>

Hi,

exon@op5.se (Andreas Ericsson) writes:

[snip]
> As a nice side-effect, the patch also fixes the problem with
> 	make
> 	make prefix=/usr install
>
> Signed-off-by: Andreas Ericsson <ae@op5.se>
[snip]
> +# Force rebuild so that "make prefix=<something> install" Just Works.
> +.PHONY: git

This is bad, since it does the wrong thing for the correct way:

  make prefix=/usr
  sudo make prefix=/usr install

With your patch 'git' will be compiled as root.

- Hari