From: Jakub Narebski <jnareb@gmail.com>
Date: Sat, 10 Dec 2011 11:57:59 GMT
Subject: Re: [PATCHv3 11/13] strbuf: add strbuf_add*_urlencode
Message-ID: <m3iplohc6s.fsf@localhost.localdomain>
In-Reply-To: <20111210103420.GK16529@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> +void strbuf_add_urlencode(struct strbuf *sb, const char *s, size_t len,
> +			  int reserved)
> +{
> +	strbuf_grow(sb, len);

What is this `reserved` flag for, and when should one use it?
It would be nice to have a short comment...

BTW. was it meant to be aligned like this?

> +void strbuf_add_urlencode(struct strbuf *sb, const char *s, size_t len,
> +			     int reserved)


-- 
Jakub Narębski