From: Jakub Narebski <jnareb@gmail.com>
Date: Tue, 04 May 2010 17:48:31 GMT
Subject: Re: [PATCH v2] blame: add a range option to -L
Message-ID: <m3bpcvftjk.fsf@localhost.localdomain>
In-Reply-To: <7vd3xbmv4w.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> I wonder if it makes the interface more consistent to rewrite the
> above comment like this:
> 
> 	/*
> 	 * Allow "-L <something>,+20" to mean starting at <something>
> 	 * for 20 lines; "-L <something>,-5" for 5 lines ending at
> 	 * <something>; and "-L <something>,+-5" for 5 lines around
>          * <something>.
> 	 */
> 
> and the match the code.

I like this.


The other approach would be to use -B <num> / -A <num> / -C [num], -<num>
convention from 'grep'... but git-blame uses -C and -<num> for other
things.

-- 
Jakub Narebski
Poland
ShadeHawk on #git