From: Jakub Narebski <jnareb@gmail.com>
Date: Thu, 18 Sep 2008 15:13:35 GMT
Subject: Re: [PATCH] avoid gitweb uninitialized value warning
Message-ID: <m3abe5mqs8.fsf@localhost.localdomain>
In-Reply-To: <20080905182629.GA22030@kodama.kitenet.net>

Joey Hess <joey@kitenet.net> writes:
> Subject: [PATCH] avoid gitweb uninitialized value warning

I would say _where_ this uninitialized value warning was, e.g.

Subject: [PATCH] gitweb: avoid warnings for commits with no body

>
> In the ususual case when there is no commit message, gitweb would
> output an uninitialized value warning.

Typo: s/ususual/unusual/

> 
> Signed-off-by: Joey Hess <joey@kitenet.net>

Acked-by: Jakub Narebski <jnareb@gmail.com>

> ---
>  gitweb/gitweb.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 29e2156..da474d0 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -2123,7 +2123,7 @@ sub parse_commit_text {
>  			last;
>  		}
>  	}
> -	if ($co{'title'} eq "") {
> +	if (! defined $co{'title'} || $co{'title'} eq "") {

I would avoid space between logical negation operator '!' and
its operand, i.e. I would write:

+	if (!defined $co{'title'} || $co{'title'} eq "") {

>  		$co{'title'} = $co{'title_short'} = '(no commit message)';
>  	}
>  	# remove added spaces
> -- 
> 1.5.6.5
> 
> -- 
> see shy jo

-- 
Jakub Narebski
Poland
ShadeHawk on #git