From: Jakub Narebski <jnareb@gmail.com>
Date: Sat, 08 Dec 2007 16:13:45 GMT
Subject: Re: [PATCH] gitweb: Make config_to_multi return [] instead of [undef]
Message-ID: <m38x45tb9y.fsf@roke.D-201>
In-Reply-To: <20071208123058.7364.25491.stgit@rover>

Petr Baudis <pasky@suse.cz> writes:

> This is important for the list of clone urls, where if there are
> no per-repository clone URL configured, the default base URLs
> are never used for URL construction with this patch.

Thanks.
 
> @@ -1512,7 +1512,7 @@ sub config_to_int {
>  sub config_to_multi {
>  	my $val = shift;
>  
> -	return ref($val) ? $val : [ $val ];
> +	return ref($val) ? $val : $val ? [ $val ] : [];
>  }

Shouldn't it be

  +	return ref($val) ? $val : defined($val) ? [ $val ] : [];

-- 
Jakub Narebski