From: Jakub Narebski <jnareb@gmail.com>
Date: Thu, 09 Dec 2010 23:30:10 GMT
Subject: Re: [PATCH 01/18] gitweb: Prepare for splitting gitweb
Message-ID: <m37hfi34q2.fsf@localhost.localdomain>
In-Reply-To: <1291931844-28454-2-git-send-email-warthog9@eaglescrag.net>

"John 'Warthog9' Hawley" <warthog9@eaglescrag.net> writes:

> From: Jakub Narebski <jnareb@gmail.com>
> +install-modules:
> +	install_dirs="$(sort $(dir $(GITWEB_MODULES)))" && \
> +	for dir in $$install_dirs; do \
> +		test -d '$(DESTDIR_SQ)$(gitweblibdir_SQ)/$$dir' || \
> +		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitweblibdir_SQ)/$$dir'; \

This should be

  +		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitweblibdir_SQ)'/$$dir; \

or even

  +		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitweblibdir_SQ)'/"$$dir"; \

Shell variables should be not inside single quotes (as oposed to make
variables, where it does not matter).

Please rebase on top of v7.4, where it was fixed.
-- 
Jakub Narebski
Poland
ShadeHawk on #git