From: Jakub Narebski <jnareb@gmail.com>
Date: Fri, 07 Mar 2008 16:59:30 GMT
Subject: Re: [PATCH v2 2/3] git-submodule: New subcommand 'summary' (2) - hard work
Message-ID: <m34pbih3m9.fsf@localhost.localdomain>
In-Reply-To: <46dff0320803070850w290bfbe6hcdf74b20fcd7d8a4@mail.gmail.com>

"Ping Yin" <pkufranky@gmail.com> writes:

> On Sat, Mar 1, 2008 at 3:29 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Ping Yin <pkufranky@gmail.com> writes:
>>
>>> +             test -z "$check_src" ||
>>> +             GIT_DIR="$name/.git" git-rev-parse --verify $sha1_src^0 >/dev/null 2>&1 ||
>>> +             unfound_src=t
>>
>>  You do not want to do ^0; you will not be bind a non-commit in gitlink
>>  entry anyway.
>>
> Actually, I need ^0. "git-rev-parse --verify sha1" will always
> succeed if sha1 is an valid name with lenght 40 even if the sha1
> doesn't belong to the repository.
>
> But what I want to verify is that the sha1 is not just valid/unique
> but also belongs to the submodule repository.

Don't you want "git cat-file -e <sha1>" then, unless you are checking
more than one sha1?

-- 
Jakub Narebski
Poland
ShadeHawk on #git