From: Atharva Raykar <raykar.ath@gmail.com>
Date: Fri, 06 Aug 2021 11:16:37 GMT
Subject: Re: [GSoC] [PATCH v2 5/9] submodule--helper: remove constness of sm_path
Message-ID: <m2zgtuu8kq.fsf@gmail.com>
In-Reply-To: <xmqqeeb7k4kl.fsf@gitster.g>


Junio C Hamano <gitster@pobox.com> writes:

> Atharva Raykar <raykar.ath@gmail.com> writes:
>
>> This is needed so that it can be modified by normalize_path_copy() in
>> the next patch.
>
> This is a hard-to-judge change.  With this alone, we cannot tell if
> somebody has already looked at the member (and possibly saved the
> pointer elsewhere) before "the next patch" starts modifying the
> member in the struct.  It probably should be done in a single patch
> to demonstrate why it is needed and how existing users of the field
> are OK with this change.

Okay, I will move this to the next patch.