From: Andreas Schwab Date: Sun, 30 Mar 2014 08:29:04 GMT Subject: Re: [PATCH v3] MSVC: fix t0040-parse-options crash Message-ID: In-Reply-To: <7vtxago359.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > As OPT_SET_PTR() is about setting the pointer value to intptr_t defval, > a follow-up patch on top of this fix (see attached) may not be a bad > thing to have, but that patch alone will not fix this issue without > dropping the unneeded and unwanted cast to unsigned long. Wouldn't it make sense to change defval into a union to avoid the cast? (The intptr_t type may be too narrow for other values to be put there.) Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."