From: Andreas Schwab <schwab@linux-m68k.org>
Date: Tue, 10 Apr 2012 14:41:45 GMT
Subject: Re: [PATCH] rev-parse --show-prefix: add in trailing newline
Message-ID: <m2vcl7ir86.fsf@igel.home>
In-Reply-To: <7v1unwwwov.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Because the assignment will strip the trailing LF away

No, it doesn't.  Command substitution does.

> But it will break existing scripts if they expect the following to work:
>
> 	file="$(git rev-parse --show-prefix)/$1"
>         cd_to_toplevel
>         test -f "$file"

This is already broken because of the extra slash.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."