From: Andreas Schwab Date: Sat, 19 Nov 2011 14:41:38 GMT Subject: Re: [PATCH 1/2] MSVC: Do not close stdout to prevent a crash Message-ID: In-Reply-To: <1321710345-2299-1-git-send-email-vfr@lyx.org> Vincent van Ravesteijn writes: > When compiled with MSVC, git crashes on Windows when calling > fstat(stdout) when stdout is closed. fstat is being called at the end of ITYM fileno(stdout). > run_builtin and this will thus be a problem for builtin command that close > stdout. This happens for 'format-patch' which closes stdout after a call to > freopen which directs stdout to the format patch file. It shouldn't do that in the first place. This is an error on any platform. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."