From: Atharva Raykar <raykar.ath@gmail.com>
Date: Wed, 11 Aug 2021 10:30:37 GMT
Subject: Re: [GSoC] [PATCH v5 1/9] submodule--helper: add options for compute_submodule_clone_url()
Message-ID: <m2pmuk9stu.fsf@gmail.com>
In-Reply-To: <21917b01-94f7-2698-b904-2d75f37af447@gmail.com>


Bagas Sanjaya <bagasdotme@gmail.com> writes:

> On 10/08/21 18.46, Atharva Raykar wrote:
>>   	if (git_config_get_string(remotesb.buf, &remoteurl)) {
>> -		warning(_("could not look up configuration '%s'. Assuming this repository is its own authoritative upstream."), remotesb.buf);
>> +		if (!quiet)
>> +			warning(_("could not look up configuration '%s'. "
>> +				  "Assuming this repository is its own "
>> +				  "authoritative upstream."),
>> +				remotesb.buf);
>>   		remoteurl = xgetcwd();
>>   	}
>
> Why did you split warning message? We could keep that in one line.

That line was too long, and given that I was moving the function and
changing it a little bit, I decided to make it adhere more closely to
the CodingGuidelines [1] and local convention.

[1] https://github.com/git/git/blob/6c85aac65fb455af85745130ce35ddae4678db84/Documentation/CodingGuidelines#L190