From: Andreas Schwab <schwab@linux-m68k.org>
Date: Sun, 01 Jun 2014 07:17:20 GMT
Subject: Re: [PATCH v4 1/2] refs.c: optimize check_refname_component()
Message-ID: <m2k391drpb.fsf@linux-m68k.org>
In-Reply-To: <1401599865-14117-1-git-send-email-dturner@twitter.com>

David Turner <dturner@twopensource.com> writes:

> +static unsigned char refname_disposition[] = {
> +	1, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9,
> +	9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9,
> +	9, 0, 0, 0, 0, 0, 0, 0, 0, 0, 9, 0, 0, 0, 2, 1,
> +	0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 9, 0, 0, 0, 0, 9,
> +	0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> +	0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 9, 9, 0, 9, 0,
> +	0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> +	0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 9, 9
> +};

> +		unsigned char ch = (unsigned char) *cp;
> +		char disp = refname_disposition[ch];

Undefined behaviour.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."