From: Andreas Schwab <schwab@linux-m68k.org>
Date: Mon, 19 Sep 2011 21:46:37 GMT
Subject: Re: [PATCH] git-web--browse: invoke kfmclient directly
Message-ID: <m2bougtdc2.fsf@igel.home>
In-Reply-To: <7v1uvc9qhz.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Thinking about it a bit more, I suspect that we should just let the 'eval'
> grab value out of the $browser_cmd variable, i.e.
>
> 	eval '$browser_cmd "$@"'
>
> no?

That's a Useless Use of Eval and 100% equivalent to this:

$browser_cmd "$@"

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."