From: Collin Funk <collin.funk1@gmail.com>
Date: Fri, 13 Mar 2026 14:41:46 GMT
Subject: Re: [PATCH] Signed-off-by: aum2357 <ahambrahmasmi2357@gmail.com>
Message-ID: <m1fr63zt91.fsf@gmail.com>
In-Reply-To: <20260313133937.562603-1-ahambrahmasmi2357@gmail.com>

aum2357 <ahambrahmasmi2357@gmail.com> writes:

> diff: use conventional comparison order
>
> Replace `0 <= addremove_explicit` with `addremove_explicit >= 0`
> to follow the common coding style where variables appear on the
> left side of comparisons.
> ---
>  builtin/add.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/add.c b/builtin/add.c
> index 0ee21692c2..ad0d6047af 100644
> --- a/builtin/add.c
> +++ b/builtin/add.c
> @@ -432,7 +432,7 @@ int cmd_add(int argc,
>  	argc--;
>  	argv++;
>  
> -	if (0 <= addremove_explicit)
> +	if ( addremove_explicit >= 0 )
>  		addremove = addremove_explicit;
>  	else if (take_worktree_changes && ADDREMOVE_DEFAULT)
>  		addremove = 0; /* "-u" was given but not "-A" */

See a previous thread on this topic [1].

We have a dead link in the Coreutils README-hacking that is likely to
that thread. We also generally prefer the previous ordering there.

Collin

[1] https://public-inbox.org/git/7vekbwru6x.fsf@assigned-by-dhcp.cox.net/