From: Eric W. Biederman Date: Sun, 21 May 2006 00:59:48 GMT Subject: Re: [PATCH] Implement git-quiltimport (take 2) Message-ID: In-Reply-To: <7v8xow1a6r.fsf@assigned-by-dhcp.cox.net> Junio C Hamano writes: > ebiederm@xmission.com (Eric W. Biederman) writes: > >> Currently git-mailinfo distinguishes headers and non-headers by the >> presence of the first blank line. So it seems to work just fine on >> mbox format patches. > > The program was designed to be fed one e-mail a time (the > intended way for it to work is that a wrapper script uses > git-mailsplit to break mbox up and call git-mailinfo one by > one). In this case what is meant is a leading "From " header (no colon) at the start of the patch. Where git-mailinfo is likely to fall down is more in the quilt patches from Andi Kleen. If you look at my quoted patch header below you will see the subject is a plain line, followed by a space followed by a from. On this example git-mailinfo works (except for picking up the subject) but it appears to be a fluke. >From x86_64-mm-add-abilty-to-enable-disable-nmi-watchdog-from-sysfs.patch: > Add abilty to enable/disable nmi watchdog with sysctl > > From: dzickus > > Adds a new /proc/sys/kernel/nmi call that will enable/disable the nmi > watchdog. > > Signed-off-by: Don Zickus > Signed-off-by: Andi Kleen > > --- > arch/i386/kernel/nmi.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++ > arch/x86_64/kernel/nmi.c | 48 +++++++++++++++++++++++++++++++++++++++++++ > include/asm-i386/nmi.h | 1 > include/asm-x86_64/nmi.h | 1 > include/linux/sysctl.h | 1 > kernel/sysctl.c | 11 +++++++++ > 6 files changed, 114 insertions(+) > > Index: linux/arch/i386/kernel/nmi.c Eric