From: Ben Woosley Date: Fri, 22 Apr 2016 23:16:16 GMT Subject: Re: make test Unexpected passes Message-ID: In-Reply-To: <571A8404.5030200@ramsayjones.plus.com> Ramsay Jones ramsayjones.plus.com> writes: > > Hi Ben, Junio, > > Tonight, the testsuite passed with a couple of 'unexpected passes', viz: > > In the first case, t3421-*.sh, git bisect fingered commit f32ec670 > ("git-rebase--merge: don't include absent parent as a base", 20-04-2016). > > ATB, > Ramsay Jones > Yep, These know breakages: ok 50 - rebase -m --onto --root ok 54 - rebase -m without --onto --root with disjoint history Have to do with rebasing a root/orphan branch with the -m flag, which defaults to -- merge=recursive, which is the case the patch fixed. Here are the necessary changes: --- a/t/t3421-rebase-topology-linear.sh +++ b/t/t3421-rebase-topology-linear.sh @@ -253,7 +253,7 @@ test_run_rebase () { " } test_run_rebase success '' -test_run_rebase failure -m +test_run_rebase success -m test_run_rebase success -i test_run_rebase success -p @@ -268,7 +268,7 @@ test_run_rebase () { " } test_run_rebase success '' -test_run_rebase failure -m +test_run_rebase success -m test_run_rebase success -i test_run_rebase failure -p -- 2.8.1.211.g8e54d77