From: Jun Hao <achilles.hao@gmail.com>
Date: Tue, 11 Mar 2014 18:40:55 GMT
Subject: Re: [PATCH 4/7] commit: fix patch hunk editing with
Message-ID: <loom.20140311T194024-418@post.gmane.org>
In-Reply-To: <20140311180020.GA28154@sigill.intra.peff.net>

Jeff King <peff <at> peff.net> writes:

> 
> Ah, you're right. I was thinking that our invocation of launch_editor
> also respected it. It does, but we never get there at all because
> use_editor is set to 0. So yeah, it really is just needed for the hook.
> 
> Your patch, even though it is a bigger change, keeps the setting to the
> minimal area, which is cleaner and more maintainable in the long run.
> 
> -Peff
> 

Oh, didn't realize GIT_EDITOR change is only for hooks. Good catch. I agree 
Benoit's patch is better for the long term.

Thanks - Jun