From: Eric Raible Date: Tue, 24 Aug 2010 19:07:30 GMT Subject: Re: [PATCH 2/1] do not pass "git -c foo=bar" params to transport helpers Message-ID: In-Reply-To: <20100824064114.GA20724@burratino> Jonathan Nieder gmail.com> writes: > #define GRAFT_ENVIRONMENT "GIT_GRAFT_FILE" > #define TEMPLATE_DIR_ENVIRONMENT "GIT_TEMPLATE_DIR" > #define CONFIG_ENVIRONMENT "GIT_CONFIG" > +#define CONFIG_DATA_ENVIRONMENT "GIT_CONFIG_PARAMETERS" > #define EXEC_PATH_ENVIRONMENT "GIT_EXEC_PATH" > #define CEILING_DIRECTORIES_ENVIRONMENT "GIT_CEILING_DIRECTORIES" > #define NO_REPLACE_OBJECTS_ENVIRONMENT "GIT_NO_REPLACE_OBJECTS" Given that the pattern is: #define foo_ENVIRONMENT "GIT_foo" Your addition should be: #define CONFIG_PARAMETERS_ENVIRONMENT "GIT_CONFIG_PARAMETERS" Not only that, but the first one should be: #define GRAFT_FILE_ENVIRONMENT "GIT_GRAFT_FILE"