From: Glen Choo <chooglen@google.com>
Date: Wed, 09 Mar 2022 22:11:44 GMT
Subject: Re: [PATCH v5 00/10] fetch --recurse-submodules: fetch unpopulated submodules
Message-ID: <kl6lzgly4vz3.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <xmqq4k46nae4.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Glen Choo <chooglen@google.com> writes:
>
>> To clarify, does this opinion of "don't use config values that aren't
>> copied into .git/config" extend to in-tree .gitmodules? Prior to this
>> series, we always read the in-tree .gitmodules to get the config - the
>> user does not need to copy the settings to .git/config, but we don't
>> pick a commit to read .gitmodules from.
>
> I think we do, but I also think it was a huge mistake to allow
> repository data to directly affect the behaviour of local checkout.

I'm inclined to agree.

> Fixing that is most likely outside the scope of this series, though.

Agree. Thanks!