From: Glen Choo <chooglen@google.com>
Date: Wed, 29 Sep 2021 22:53:28 GMT
Subject: Re: [PATCH v2 0/3] Use default values from settings instead of config
Message-ID: <kl6ltui3ouxj.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <CAPig+cS7PF=F0XWO-EyVz_KuLnbnhQi3N01gyozSv99PmB_1RA@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> I re-read the entire thread and left a few comments on the v2 patches.
> One or two of the comments might be actionable (i.e. deserve a
> re-roll), but most are probably subjective.

Thanks so much again!

> Oh, I forgot to mention in my review of [3/3] that in:
>
>     In the case where core.multiPackIndex is not set in the config, the auto
>     condition would fail, causing the incremental-repack task to not be
>     run. Because we always want to consider the default values, we should
>     just always just use the_repository->settings.
>
> you can probably drop one or both "just"s.

Yes, this is definitely a typo from me.