From: Glen Choo <chooglen@google.com>
Date: Thu, 25 May 2023 16:09:09 GMT
Subject: Re: [PATCH 2/2] repository: move 'repository_format_worktree_config' to repo scope
Message-ID: <kl6lsfbkxuje.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <kl6lv8ghxkpc.fsf@chooglen-macbookpro.roam.corp.google.com>

Glen Choo <chooglen@google.com> writes:

> I think it would be better to pass a "struct repository" arg to
> config_with_options() instead of mocking a config_source to hold a .repo
> member.

The flipside is that this would be redundant with an existing use of
git_config_source.repo, so for consistency, we should probably remove
git_config_source.repo. There's only one user of git_config_source.repo
- reading .gitmodules from a blob. It probably made sense to add .repo
the time, but now that we have a second, different use of "struct
repository", accepting an arg is probably better.