From: Glen Choo Date: Wed, 30 Nov 2022 18:14:05 GMT Subject: Re: ab/remove--super-prefix and -rc0 (was What's cooking in git.git (Nov 2022, #07; Tue, 29)) Message-ID: In-Reply-To: Junio C Hamano writes: > Glen Choo writes: > >> Hm, it looks like ab/remove--super-prefix missed the preview release.. >> Per the discussion ending at [1] I think my one-patch fix to "git >> fetch" [2] should have made it into the release (it's pretty low-risk >> and doesn't introduce too much churn to ab/remove--super-prefix). Is it >> too late for that? > > Nobody seemed to have commented on [2]. Is this fixing recent > regressions, or is it more like addressing an "if it hurts, do not > do it then" problem? Ævar did comment on the patch in [2], but unfortunately it happened on the thread ending at [1] (and others), so it's not easy to follow. It's solidly in the latter category. I don't think this has ever worked. c.f. https://lore.kernel.org/git/kl6lsfiivcau.fsf@chooglen-macbookpro.roam.corp.google.com/ > The fact alone that these questions need to be asked _now_ is a good > indication that it is way too late for this cycle, I would have to > say. At any rate, we shouldn't be rushing review, so this is fair (though unfortunate). Let's continue counting on ab/remove--super-prefix and ignoring my one patch, then. > > Thanks.