From: Glen Choo Date: Tue, 21 Dec 2021 00:18:31 GMT Subject: Re: [PATCH v2] builtin/fetch: skip unnecessary tasks when using --negotiate-only Message-ID: In-Reply-To: Junio C Hamano writes: > Glen Choo writes: > >> But maybe I am misunderstanding how Git treats CLI options in general? >> We don't ever really hide CLI options, even if they are only >> internal. There is PARSE_OPT_HIDDEN, but those still show up in usage >> and documentation [1]. So we actually do want users to know about these >> implementation details? > > At least they should be told not to use from the command line when > they have no business triggering whatever feature these options > trigger. Makes sense. I can add this to the docs if we think --negotiate-only isn't meant for end users. >> Presumably, the thought process goes something like this: if we add an >> option, a user *could* find a use for it (or it might accidentally >> conflict with a user's flags), even if we never intended it for end user >> consumption. Thus we need to treat all CLI options with care. > > Rather, they can keep both halves ;-) Hm, do you mean "both halves" as in, they should be able to choose whether or not they want to use an internal option?