From: Glen Choo <chooglen@google.com>
Date: Wed, 27 Jul 2022 17:07:11 GMT
Subject: Re: nonnull v.s. BUG() if !x (was: [PATCH v2] config.c: NULL check when reading protected config)
Message-ID: <kl6la68uscw0.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <220727.86v8rilxx1.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> On Tue, Jul 26 2022, Glen Choo via GitGitGadget wrote:
>
>> From: Glen Choo <chooglen@google.com>
>
>> +	if (!filename)
>> +		BUG("filename cannot be NULL");
>
> Looks good, but as an aside I wonder if we wouldn't get better code
> analysis with "nonnull" for this sort of thing, but we can leave this
> for now:
> https://gcc.gnu.org/onlinedocs/gcc-12.1.0/gcc/Common-Function-Attributes.html#Common-Function-Attributes

Interesting. I wonder how good the analysis is vs the cost, e.g. it's
useful if it detects _maybe_ NULL variables, but it might be too
expensive if it requires us to mark all of our variables as non-NULL.