From: Joachim Schmitz Date: Fri, 14 Dec 2012 07:54:40 GMT Subject: Re: Build fixes for another obscure Unix Message-ID: In-Reply-To: David Michael wrote: > Hi, > > On Thu, Dec 13, 2012 at 12:18 PM, Pyeron, Jason J CTR (US) > wrote: >>> Would there be any interest in applying such individual >>> compatibility fixes for this system, even if a full port doesn't >>> reach completion? >> >> What are the down sides? Can your changes be shown to not impact >> builds on other systems? > > I've pushed a handful of small compatibility patches to GitHub[1] > which are enough to successfully compile the project. The default > values of the new variables should make them unnoticeable to other > systems. > > Are there any concerns with this type of change? If they would be > acceptable, I can try sending the first four of those patches to the > list properly. (I expect the last two may be tweaked as I continue > working with the port.) > > I do have a concern with strings.h, though. That file will be > included for most people who run ./configure, when it wasn't before. > Do you think it's worth making a more detailed test to see if > strcasecmp is still undefined after string.h is included, rather than > just testing for the header's existence? > > Thanks. > > David > > [1] https://github.com/dm0-/git/commits For what's it worth: I ACK your HP-NonStop patch (as you can see by my comment in git-compat-util.h I was thinking along the same line) https://github.com/dm0-/git/commit/933d72a5cfdc63fa9c3c68afa2f4899d9c3f791e together with its prerequisit https://github.com/dm0-/git/commit/301032c6488aeabb94ccc81bfb6d65ff2c23b924 ACKed by: Joachim Schmitz