From: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date: Mon, 25 Aug 2025 18:11:21 GMT
Subject: Re: [PATCH] progress: pay attention to (customized) delay time
Message-ID: <jq5ul4zwdex6peuub3upwzxz3d5zcnuh7adseyg6wa6dpiu4ci@fuwe2t2vbguo>
In-Reply-To: <xmqq349fs5ee.fsf@gitster.g>

On Mon, Aug 25, 2025 at 10:00:25AM -0800, Junio C Hamano wrote:
> 
> >  	struct strbuf *counters_sb = &progress->counters_sb;
> >  	int show_update = 0;
> > +	sig_atomic_t update = progress_update;
> 
> It is somewhat misleading to use sig_atomic_t for "update", which is
> never updated via the signal handler.  It confused me a bit during
> my initial reading.  If it were
> 
> 	int update = !!progress_update;
> 
> it would have made it more obvious what is going on, at least to me.

In that case, I would suggest doing instead:

  bool update = !!progress_update;

Carlo