From: Justin Tobler <jltobler@gmail.com>
Date: Tue, 23 Sep 2025 15:56:25 GMT
Subject: Re: [PATCH 2/4] builtin/repo: add object counts in stats output
Message-ID: <jp2pzjazi6w6pm4jv7bk2c3gywksezpaoufd6aulcdxr4tbqi4@k3fjsgvejp5m>
In-Reply-To: <CAOLa=ZTihUt0d-3_LOydX4GxWPSquAOWkzw3+0XzM-zp6wFZ+w@mail.gmail.com>

On 25/09/23 10:30AM, Karthik Nayak wrote:
> Justin Tobler <jltobler@gmail.com> writes:
> 
> [snip]
> 
> > @@ -159,13 +161,25 @@ static int repo_info(int argc, const char **argv, const char *prefix,
> >  	return print_fields(argc, argv, repo, format);
> >  }
> >
> > -struct stats {
> > +struct ref_stats {
> >  	size_t branches;
> >  	size_t remotes;
> >  	size_t tags;
> >  	size_t others;
> >  };
> >
> > +struct object_stats {
> > +	size_t tags;
> > +	size_t commits;
> > +	size_t trees;
> > +	size_t blobs;
> > +};
> > +
> > +struct stats {
> > +	struct ref_stats refs;
> > +	struct object_stats objects;
> > +};
> > +
> 
> Okay so we do use nested structs, which I mentioned in the previous
> commit, so we're all good.
> 
> Nit: A lot of the diff in this commit is because we don't make the
> required structs in the previous commit. Perhaps we could start with the
> nested structs in the previous commit? That way this patch would be much
> simpler.

Ya, I clean this up in the next version.

-Justin