From: Ævar Arnfjörð Bjarmason Date: Tue, 06 Apr 2010 08:42:10 GMT Subject: Re: [PATCH] Add option to git-commit to allow empty log messages Message-ID: In-Reply-To: <20100406055530.GE3901@coredump.intra.peff.net> On Tue, Apr 6, 2010 at 05:55, Jeff King wrote: > On Mon, Apr 05, 2010 at 12:58:22PM -0500, Jonathan Nieder wrote: > >> > There's probably a lot of code out there doing `git commit -m"Yet >> > another revision"' from some cron job. >> >> FWIW, I have no strong opinion about whether to add this --allow-empty-message >> option.  Maybe it would make something more convenient for someone, >> though that has to be weighed against it making it harder for everyone >> else to read the manual. > > I meant to mention this in my other response: I would prefer if such an > option doesn't clutter up the usage message. --allow-empty is already > there, and probably doesn't need to be. "git commit -h 2>&1 | wc -l" > shows a whopping 39 lines, which IMHO is too many for a short usage > summary. I mean, "--no-post-rewrite", is that really one of the top-used > options? I just put it there because --allow-empty was there and I thought the SYNOPSIS might be going for a complete listing. I completely agree though, the option shouldn't be in the SYNOPSIS, and neither should --allow-empty be. They're both analogous to obscure options like --porcelain (which isn't listed). I've just submitted a new patch to rectify this. I can send another one to remove --allow-empty from the SYNOPSIS.