From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Tue, 20 Jul 2010 18:19:14 GMT
Subject: Re: [PATCH] t/README: clarify test_must_fail description
Message-ID: <gSJqoMSCdnNZVG9-DiMIs9GCIi5KJ7c0V35BPIQOHLVdP1L6ZeO3iA@cipher.nrlssc.navy.mil>
In-Reply-To: <7veieym3sh.fsf@alter.siamese.dyndns.org>

On 07/20/2010 01:00 PM, Junio C Hamano wrote:

> How about being more explicit?
> 
>     Run a git command and ensure it fails in a controlled way.  Use
>     this instead of "! <git-command>".  When git-command dies due to a
>     segfault, test_must_fail diagnoses it as an error; "! <git-command>"
>     treats it as just another expected failure. letting such a bug go
>     unnoticed.

Much better.  If you want the last sentence to be grammatically correct,
you could rephrase it like this:

   ...just another expected failure, which would let such a bug go unnoticed.

-brandon