From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Thu, 19 Jun 2008 17:44:23 GMT
Subject: Re: [PATCH] t7502-commit.sh: test_must_fail doesn't work with inline environment variables
Message-ID: <gASAIyn4TvarEmVo9rWtEKa6eROfKXwowHxH6j05FzPARJ-CDBCHLw@cipher.nrlssc.navy.mil>
In-Reply-To: <20080619173932.GA32593@glandium.org>

Mike Hommey wrote:
> On Thu, Jun 19, 2008 at 12:32:02PM -0500, Brandon Casey wrote:
>> -	test_must_fail GIT_EDITOR="$(pwd)/.git/FAKE_EDITOR" git commit &&
>> +	# We intentionally do not use test_must_fail on the next line since the
>> +	# mechanism does not work when setting environment variables inline
>> +	! GIT_EDITOR="$(pwd)/.git/FAKE_EDITOR" git commit &&
> 
> Doesn't GIT_EDITOR="$(pwd)/.git/FAKE_EDITOR" test_must_fail git commit
> work ?

That leaves GIT_EDITOR set to the new value after the command completes.

-brandon