From: Nick Edelen Date: Tue, 06 Apr 2010 21:40:35 GMT Subject: Re: [PATCH 2/7 (v5)] basic api and porcelain Message-ID: In-Reply-To: > head.signature is 8 characters (see below), and so is "REVCACHE".  Surely > either > head.signature needs to be 9 characters, or you shouldn't use strcpy. > Indeed, mostly you do seem to be using memcpy ... aw shit, don't know how those slipped in there... managed to do that with slice pointer initialization too. looks like I might have to do another submission later.