From: Jakub Narebski Date: Fri, 11 Jan 2008 09:14:01 GMT Subject: Re: [PATCH] bundle, fast-import: detect write failure Message-ID: In-Reply-To: <20080110162526.GB27808@artemis.madism.org> Pierre Habouzit wrote: > On Thu, Jan 10, 2008 at 01:00:15PM +0000, Jim Meyering wrote: >> However, even if it's not technically required to fail at that point, >> if it were my choice, I'd prefer to know when a .keep file whose >> contents are unimportant just happens to reside on a bad spot on my >> disk. I/O errors should never be ignored. > > Actually I think .keep files are empty, so the write() should not be > there in the first place, and we should only check for close() right ? > not that it matters that much. In theory the .keep file should contain description _why_ the pack is made kept. In practice git creates IIRC empty .kep files. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git