From: Phillip Wood <phillip.wood123@gmail.com>
Date: Fri, 01 Apr 2022 15:20:52 GMT
Subject: Re: [PATCH v4 08/27] revision.[ch]: document and move code declared around "init"
Message-ID: <ffb2f216-4504-b1d7-6b59-55c09df4f5d1@gmail.com>
In-Reply-To: <patch-v4-08.27-086cec742b4-20220331T005325Z-avarab@gmail.com>

Hi Ævar

On 31/03/2022 02:11, Ævar Arnfjörð Bjarmason wrote:
> A subsequent commit will add "REV_INFO_INIT" macro adjacent to
> repo_init_revisions(), unfortunately between the "struct rev_info"
> itself and that function we've added various miscellaneous code
> between the two over the years.
> 
> Let's move that code either lower in revision.h, giving it API docs
> while we're at it, or in cases where it wasn't public API at all move
> it into revision.c No lines of code are changed here, only moved
> around. The only changes are the addition of new API comments.

It's nice to see to see the API being documented

 >[...]
>   
> +/**
> + * Helpers to check if a "struct string_list" item matches wild
> + * wildmatch().

wild wildmatch()??

Best Wishes

Phillip