From: Sven Strickroth <email@cs-ware.de>
Date: Sat, 23 Oct 2021 14:57:59 GMT
Subject: Re: Git silently broke push-options over ssh?
Message-ID: <ff7ff6ca-2941-c61e-f36d-0732b367fc64@cs-ware.de>
In-Reply-To: <YXMku8V9cdHLfXt6@coredump.intra.peff.net>

Am 22.10.2021 um 22:53 schrieb Jeff King:
> On Fri, Oct 22, 2021 at 07:27:14PM +0200, Sven Strickroth wrote:
> 
>> If I understood <https://opensource.googleblog.com/2018/05/introducing-git-protocol-version-2.html>
>> correctly I have to enable the Git protocol version 2 and then the push
>> options should work.
> 
> I don't think that is true. There is no v2 push protocol yet, so the
> push options must work over v0.

You are right. After enabling GIT_TRACE_PACKET I see that the 
push-option gets transmitted correctly.

I got confused was because a GitLab CI pipeline run despite I passed 
ci.skip. The reason why the pipeline ran despite of that flag is that 
some external push hook triggered a CI pipeline action manually - when I 
look at GitLab immediately after the push I see that the pipeline is 
skipped and then the external hook fires...

Thanks for the hint for enabling GIT_TRACE_PACKET  Peff and sorry for 
the noise.

  Sven