From: Phillip Wood Date: Tue, 27 Feb 2024 14:00:22 GMT Subject: Re: [PATCH v5 0/2] Implement `git log --merge` also for rebase/cherry-pick/revert Message-ID: In-Reply-To: <20240225-ml-log-merge-with-cherry-pick-and-other-pseudo-heads-v5-0-af1ef2d9e44d@gmail.com> On 25/02/2024 21:56, Philippe Blain wrote: > Changes in v5: > - Marked error messages for translation and tweaked them as suggested by Phillip > - Reworded the message of 2/2 as suggested by Phillip > - Removed the change to gitk's doc in 2/2 as pointed out by Johannes > - Fixed the trailers in 2/2 > - Improved the doc in 2/2 as suggested by Phillip and Jean-Noël These changes look good, thanks for making them. I agree with the other reviewers that it would be nice to improve the wording of the error message when we find a symbolic ref. Everything else looks good to me. Thanks Phillip