From: Jeff Hostetler Date: Tue, 21 Nov 2017 20:46:09 GMT Subject: Re: [PATCH v4 00/15] Parial clone part 3: clone, fetch, fetch-pack, upload-pack, and tests Message-ID: In-Reply-To: <20171121101702.663a52515070faf73a97f2b8@google.com> On 11/21/2017 1:17 PM, Jonathan Tan wrote: > On Thu, 16 Nov 2017 18:17:08 +0000 > Jeff Hostetler wrote: > >> From: Jeff Hostetler >> >> This part 3 of a 3 part sequence partial clone. It assumes >> that part 1 and part 2 are in place. >> >> This patch series is labeled as V4 to keep it in sync with >> the corresponding V4 versions of parts 1 and 2. There was >> not a V3 version of this patch series. >> >> Jonathan and I independently started on this task. This is another >> pass at merging those efforts. So there are several places that may >> need refactoring and cleanup, but fewer than in the previous submission. >> In particular, the test cases should be squashed and new tests added. >> >> And I think we need more end-to-end tests. I'll work on those next. > > I think that it would be easier to review if the test for each command > was contained in the same patch as (or the patch immediately following) > the implementation of the command - for example, as in my modifications > [1]. > > (If you're about to send out v5, that's fine - maybe take this in > consideration for v6, if there is one.) > > [1] https://github.com/jonathantanmy/git/commits/pc20171103 > I've already pulled the tests to be with the code changes in part 1 and part 2. There are a few commits with tests in part 3 that we may want to squash together, but we can do that later. If you want to start with my V5 set and do that, that would be fine. What I was talking about above are some additional end-to-end tests that I think we need. For example, do a partial clone/fetch and then run blame or some other commands that exercise the overall system. As parts 1, 2, and 3 are settling down, these additional tests could be in a part 4 for now. Later, if it makes sense, these could be move earlier. Jeff