From: René Scharfe <l.s.r@web.de>
Date: Mon, 23 Mar 2020 17:09:39 GMT
Subject: Re: [PATCH] import-tars: ignore the global PAX header
Message-ID: <fce519db-5ad4-270f-abcf-0e26549486cb@web.de>
In-Reply-To: <pull.577.git.1584968924555.gitgitgadget@gmail.com>

Am 23.03.20 um 14:08 schrieb Johannes Schindelin via GitGitGadget:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Git's own `git archive` inserts that header, but it often gets into the
> way of `import-tars.perl` e.g. when a prefix was specified (for example
> via `--prefix=my-project-1.0.0/`, or when downloading a `.tar.gz` from
> GitHub releases): this prefix _should_ be stripped.
>
> Let's just skip it.

git archive uses a global pax header to pass the ID of the archived
commit as a comment, and for mtime values after 2242-03-16.  Ignoring it
in a simple importer seems reasonable for now, but I don't understand
how this relates to prefixes.  Is it because the header is treated as a
regular file with the full path "pax_global_header" (independently from
any prefix for actual files) and can thus be placed outside the expected
destination directory?

Thanks,
René