From: Nguyen Thai Ngoc Duy Date: Wed, 20 Jan 2010 12:58:54 GMT Subject: Re: git-status segmentation fault in master / OS X Message-ID: In-Reply-To: <57518fd11001200243v416aa5f9o37a3b5b92bef3b57@mail.gmail.com> On 1/20/10, Jonathan del Strother wrote: > One thing I wondered about from that commit - shouldn't the "buf = > xmalloc(size);" on dir.c:252 be "buf = xmalloc(size+1);" ? I haven't > really looked at the program flow there, so may be wrong... You would also need to revert 66c3fa0 (Avoid writing to buffer in add_excludes_from_file_1() - 2009-08-20) and see if it fixes the problem. I think there is a potential memory corruption at "buf[i - (i && buf[i-1] == '\r')] = 0;". Don't know if it is the cause though. -- Duy