From: Nguyen Thai Ngoc Duy Date: Mon, 04 Jan 2010 10:14:00 GMT Subject: Re: [PATCH] grep: do not do external grep on skip-worktree entries Message-ID: In-Reply-To: <7vbphaquwl.fsf@alter.siamese.dyndns.org> On Mon, Jan 4, 2010 at 12:52 PM, Junio C Hamano wrote: >> I agree that Solaris default tools are insane, but is there any reason >> to munge the PATH for a single feature like external grep? Why not >> EXTERNAL_GREP=/usr/xpg4/bin/grep (or /usr/local/bin/grep) in the >> Makefile? Why not GIT_EXTERNAL_GREP=$HOME/bin/grep in the environment? > > That git-sh-setup "fix" is not for running external grep.  It is for our > scripted Porcelains that rely on working basic tools (sed, tr, who knows > what else is broken). > > In fact, our Makefile by default punts on external grep on Sun's.  Run > "git grep NO_EXTERNAL_GREP -- Makefile" to see for yourself --- it would > work even on Solaris ;-) A bit off-topic. But it seems to me on linux (main development platform?) GNU grep may be tested more than the builtin grep because NO_EXTERNAL_GREP would be undefined by default. Should we test both greps in that case? -- Duy