From: Nguyen Thai Ngoc Duy Date: Mon, 30 Nov 2009 13:18:20 GMT Subject: Re: [RFC/PATCH] t7011: Mark fixed test as such Message-ID: In-Reply-To: <4B13BF3D.7010503@drmicha.warpmail.net> On 11/30/09, Michael J Gruber wrote: > Regarding 16/17: Seeing a FIXED is very misleading. I caught it during > my work on a patch series and was confused. FIXED usually occurs only > while working on a fix, before adjusting the test. So, unless the reroll > of nd/sparse is to happen very soon, I still suggest marking it as > expect_success as proposed, and then modifying the test during the reroll. I won't work on it until this weekend. If you insist, then better put command "true" after test_must_fail to indicate that the test is broken (could be line-wrapped by gmail, but it's simple enough to recreate) diff --git a/t/t7011-skip-worktree-reading.sh b/t/t7011-skip-worktree-reading.sh index e996928..da8dcbb 100755 --- a/t/t7011-skip-worktree-reading.sh +++ b/t/t7011-skip-worktree-reading.sh @@ -152,6 +152,7 @@ test_expect_failure 'commit on skip-worktree absent entries' ' git reset && setup_absent && test_must_fail git commit -m null 1 + true ' test_expect_failure 'commit on skip-worktree dirty entries' ' -- Duy