From: Nguyen Thai Ngoc Duy Date: Thu, 21 May 2009 22:57:49 GMT Subject: Re: [PATCH v0 3/3] Build in git-rebase.sh Message-ID: In-Reply-To: <200905211429.13831.jnareb@gmail.com> On Thu, May 21, 2009 at 10:29 PM, Jakub Narebski wrote: >>> [...] >>> >>> Couldn't you use parseopt also in subcommands? >> >> I don't understand. You mean parseopt for --continue, --skip and >> --abort? > > Yes. I don't know if it possible, and if it would make sense, but it > seems strange to me having both parseopts in main, and strcmp > comparisons for other parts... Ah you meant --interactive. It's because git-rebase--interactive.sh is a separate command and it needs full arguments. parseopts eats arguments. I'm too lazy to rebuild argv after being eaten by parseopts. So just search for "interactive" sign, then pass them all to git-rebase--interactive.sh (until git-rebase--interactive.sh is built in) -- Duy