From: Nguyen Thai Ngoc Duy Date: Wed, 22 Oct 2008 14:04:34 GMT Subject: Re: [PATCH] rehabilitate 'git index-pack' inside the object store Message-ID: In-Reply-To: On 10/22/08, Johannes Schindelin wrote: > So I propose this change in semantics: > > - setup_git_directory_gently(): rename to discover_git_directory(), > and avoid any chdir() at all. > - setup_git_directory(): keep the semantics that it chdir()s to the > worktree, or to the git directory for bare repositories. > > Using _gently() even for RUN_SETUP builtins should solve the long standing > pager problem, too. One more thing: "git foo -h" with RUN_SETUP won't run if repository is not found. Maybe just drop RUN_SETUP and let subcommands call setup_git_directory() -- Duy