From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Tue, 11 Mar 2008 15:06:23 GMT
Subject: Re: [PATCH 03/10] Make get_git_dir() and 'git rev-parse --git-dir' absolute path
Message-ID: <fcaeb9bf0803110806u43fbd8b8v3ec2adf84fa1cd5e@mail.gmail.com>
In-Reply-To: <alpine.LSU.1.00.0803111420080.3873@racer.site>

On Tue, Mar 11, 2008 at 8:20 PM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
>
>  On Sun, 2 Mar 2008, Nguyễn Thái Ngọc Duy wrote:
>
>  >
>  > Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>
>  I do not like this change.  It is IMO completely unnecessary, and might
>  break assumptions.

It could. And I tried my best to make sure it did not break anything.
It is also documented (if not clearly, I can correct the document).
While it's not really necessary, it would be IMHO a good change as you
would not have to rely on `cwd` anymore (that would mean whether
moving cwd by prefix or not would no longer matter).

>  Ciao,
>  Dscho
>
-- 
Duy